Fix issue with custom snapshot location attribute#19
Open
jterry75 wants to merge 1 commit intopublish-crifrom
Open
Fix issue with custom snapshot location attribute#19jterry75 wants to merge 1 commit intopublish-crifrom
jterry75 wants to merge 1 commit intopublish-crifrom
Conversation
Owner
Author
|
@kevpar, @katiewasnothere - Still testing but please review. |
jterry75
force-pushed
the
fix_snapshot_loc
branch
from
00335f4 to
8a4d523
Compare
1. Resolves an issue with using a custom snapshot location if the new location is on another drive the final os.Rename fails. Instead we now copy to the new location with its final name in one step. 2. Resolves an issue with using a custom snapshot location where if a parent layer path had a custom snapshot location the parentLayerPaths array would be incorrect. 3. Resolves an issue with using a custom snapshot location on removal we would leak the sandbox.vhdx at the custom location. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
jterry75
force-pushed
the
fix_snapshot_loc
branch
from
8a4d523 to
090fecc
Compare
|
|
||
| if loc, ok := snapshotInfo.Labels[rootfsLocLabel]; ok { | ||
| if s, err := os.Stat(loc); err != nil || !s.IsDir() { | ||
| return nil, errors.Wrapf(err, "invalid %q override: %q, bust be an existing directory", rootfsLocLabel, loc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is on another drive the final os.Rename fails. Instead we now copy to the new
location with its final name in one step.
layer path had a custom snapshot location the parentLayerPaths array would be
incorrect.
leak the sandbox.vhdx at the custom location.
Signed-off-by: Justin Terry (VM) juterry@microsoft.com